Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8275439: Remove PrintVtableStats #6017

Closed
wants to merge 1 commit into from
Closed

8275439: Remove PrintVtableStats #6017

wants to merge 1 commit into from

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Oct 19, 2021 •
edited by openjdk bot

PrintVtableStats has not been very useful and reported information may not be accurate neither. Please see the CR and comments in JDK-8275413 for details.

  • PrintVtableStats is none product flag, so does not require a CSR to remove it.
  • The patch also removes Klass::array_klasses_do() and families, as PrintVtableStats is the last use.
  • InstanceKlass/ArrayKlass::array_klasses_do(void f(Klass* k, TRAPS), TRAPS) have no use, remove them as well.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6017/head:pull/6017
$ git checkout pull/6017

Update a local copy of the PR:
$ git checkout pull/6017
$ git pull https://git.openjdk.java.net/jdk pull/6017/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6017

View PR using the GUI difftool:
$ git pr show -t 6017

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6017.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 19, 2021

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 19, 2021
@openjdk
Copy link

openjdk bot commented Oct 19, 2021

@zhengyu123 The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Oct 19, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 19, 2021

Webrevs

coleenp
coleenp approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! thanks!

@openjdk
Copy link

openjdk bot commented Oct 19, 2021 •
edited

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275439: Remove PrintVtableStats

Reviewed-by: coleenp, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 54 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 19, 2021
@zhengyu123
Copy link
Contributor Author

Thanks, @coleenp

dholmes-ora
dholmes-ora approved these changes Oct 19, 2021
View reviewed changes
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Thanks,
David

@zhengyu123
Copy link
Contributor Author

Thanks, @dholmes-ora

@zhengyu123
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 20, 2021

Going to push as commit 135cf3c.
Since your change was applied there have been 58 commits pushed to the master branch:

  • 50a5723: 8274910: Compile in G1 evacuation failure injection code based on define
  • 5454a76: 8275273: Add missing HtmlStyle documentation
  • bd0bed7: 8273317: crash in cmovP_cmpP_zero_zeroNode::bottom_type()
  • 77b2789: 7124287: [macosx] JTableHeader doesn't get focus after pressing F8 key
  • c24fb85: 8275512: Upgrade required version of jtreg to 6.1
  • 926966b: 8275003: Suppress warnings on non-serializable non-transient instance fields in windows mscapi
  • e63c148: 8264849: Add KW and KWP support to PKCS11 provider
  • bd2b41d: 8275252: Migrate cacerts from JKS to password-less PKCS12
  • 54a29a4: 8192931: Regression test java/awt/font/TextLayout/CombiningPerf.java fails
  • 4b9303b: 8273308: PatternMatchTest.java fails on CI
  • ... and 48 more: https://git.openjdk.java.net/jdk/compare/1afddb2560504c533d30b2f79d735f59f519e7c5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 20, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 20, 2021
@openjdk
Copy link

openjdk bot commented Oct 20, 2021

@zhengyu123 Pushed as commit 135cf3c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coleenp coleenp coleenp approved these changes

@dholmes-ora dholmes-ora dholmes-ora approved these changes

Assignees
No one assigned
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
3 participants
@zhengyu123 @coleenp @dholmes-ora